Conversation
d9783fc to
bbd48a7
Compare
MatteoK
left a comment
There was a problem hiding this comment.
Almost all of the many changes are copying over code 1to1 from auth0-extension-tools to remove the dependency. Refactorings have been made to
- users.js
- server.js
- apiCall.js
The refactorings maintain the existing behavior and look logically sound.
We have tested the branch via manual testing and integration testing.
Once the /develop paths are reverted again this is good to go imo
| "exponent": "AQAB", | ||
| "fingerprint": "16:E1:57:AE:1E:78:20:97:C8:89:92:96:57:91:B6:4B:19:89:5A:97" | ||
| }, | ||
| "bar": { |
There was a problem hiding this comment.
new certs are required for the session manager tests
| @@ -0,0 +1,64 @@ | |||
| // Mock fetch to work with nock | |||
There was a problem hiding this comment.
This branch upgraded the auth0 SDK to v4, which switched its HTTP transport from superagent/axios to the native fetch API (backed by undici in Node.js 22).
The problem is that nock works by monkey-patching Node's http and https modules. The old SDK used axios/superagent which route through those modules, so nock's interceptors caught everything. Native fetch uses undici internally and bypasses http/https entirely, making all nock mocks invisible to it.
fetch-mock.js fixes this by replacing global.fetch with a custom implementation that re-routes requests back through http/https — exactly the modules nock patches. The Auth0 SDK calls fetch, gets this shim instead, which uses http.request/https.request, which nock intercepts as normal.
✏️ Changes
auth0-extension-toolslibrary and ports in code and tests, and does some small refactors + fixes.📷 Screenshots
If there were visual changes to the application with this change, please include before and after screenshots here. If it has animation, please use screen capture software like to make a gif.
🔗 References
🎯 Testing
✅ This change has been tested in a Webtask
✅ This change has unit test coverage
✅ This change has integration test coverage
✅ This change has been tested for performance
🚀 Deployment
✅ This can be deployed any time
🎡 Rollout
In order to verify that the deployment was successful we will conduct smoke testing in a prod tenant.
🔥 Rollback
We will rollback if we detect issues with the new release
📄 Procedure
In order to recover quickly, we will revert these changes and release them as the next patch version,
2.13.4